besties/yellowcab
6
1
Fork 1
Code Issues Pull requests Packages Projects Releases Wiki Activity

Spotify & database support #1

Merged
h merged 34 commits from astro/yellowcab:main into main 2023-11-03 20:10:23 -04:00
Conversation 4 Commits 34 Files changed 13 +825 -33
astro commented 2023-10-25 18:50:56 -04:00
Owner
Copy link

:3

:3
astro added 9 commits 2023-10-25 18:50:56 -04:00
astro added 1 commit 2023-10-25 19:05:36 -04:00
astro added 1 commit 2023-10-25 19:05:59 -04:00
h added 1 commit 2023-10-25 19:20:47 -04:00
h added 1 commit 2023-10-25 19:35:31 -04:00
astro added 1 commit 2023-10-25 19:46:07 -04:00
astro added 1 commit 2023-10-25 20:12:39 -04:00
h added 1 commit 2023-10-25 21:43:06 -04:00
astro added 1 commit 2023-10-26 00:28:28 -04:00
astro added 2 commits 2023-10-26 10:56:49 -04:00
astro added 1 commit 2023-10-26 11:54:47 -04:00
astro added 2 commits 2023-10-26 13:30:30 -04:00
astro added 1 commit 2023-10-26 13:49:06 -04:00
astro added 1 commit 2023-10-26 19:04:55 -04:00
astro added 2 commits 2023-10-26 23:27:44 -04:00
astro added 1 commit 2023-10-26 23:35:21 -04:00
astro added 1 commit 2023-10-26 23:59:33 -04:00
astro added 1 commit 2023-10-27 00:38:09 -04:00
astro added 1 commit 2023-10-27 00:41:08 -04:00
astro added 2 commits 2023-10-27 01:01:28 -04:00
h commented 2023-10-27 01:05:12 -04:00
Owner
Copy link

Adding this note from the private Discord here so it can easily be found:
the Last Played fallback seems to currently show the second most recent track rather than the current track- I'll be looking into this when I get a chance tomorrow (er, today? it's midnight. I mean later the 27th.)

I'll also clean up the HTTP request code- currently we have code to check the HTTP status codes in multiple locations, and have the code to JSON unmarshal in multiple places as well, we should not be repeating ourselves like that.

Other than that, I think this is a really good start. We should also probably clean up the authentication flow but we can do that in a follow-up PR, it's not as important as getting the feature at all

Adding this note from the private Discord here so it can easily be found: the Last Played fallback seems to currently show the second most recent track rather than the current track- I'll be looking into this when I get a chance tomorrow (er, today? it's midnight. I mean later the 27th.) I'll also clean up the HTTP request code- currently we have code to check the HTTP status codes in multiple locations, and have the code to JSON unmarshal in multiple places as well, we should not be repeating ourselves like that. Other than that, I think this is a really good start. We should also probably clean up the authentication flow but we can do that in a follow-up PR, it's not as important as getting the feature at all
astro commented 2023-10-27 01:10:03 -04:00
Author
Owner
Copy link

The API for recently played (limit=1) seems to return one of the more recent ones, not exactly the second most recent - from my testing, one of the last 5-8. The API also doesn't show the most recent song or two when using a higher limit - most likely something on Spotify's end.

The API for recently played (limit=1) seems to return one of the more recent ones, not exactly the second most recent - from my testing, one of the last 5-8. The API also doesn't show the most recent song or two when using a higher limit - most likely something on Spotify's end.
👍 1
h commented 2023-10-27 01:15:50 -04:00
Owner
Copy link

I'm not surprised- Last.FM is sometimes slow to record Spotify scrobbles, the late WavyFM (rest in peace) had that same issue. Unrelated, of course, but it's just not too surprising Spotify's API has some problems. I'll see if there's something we can do to make this work better but as you said this does seem to be on their end and I doubt there's too much we can do

I'm not surprised- Last.FM is sometimes slow to record Spotify scrobbles, the late WavyFM (rest in peace) had that same issue. Unrelated, of course, but it's just not too surprising Spotify's API has some problems. I'll see if there's something we can do to make this work better but as you said this does seem to be on their end and I doubt there's too much we can do
astro commented 2023-10-27 08:32:21 -04:00
Author
Owner
Copy link

Linking to a (old, but sill apparently relevant) Spotify community post about this endpoint

Linking to a (old, but sill apparently relevant) [Spotify community post](https://community.spotify.com/t5/Spotify-for-Developers/Recently-played-API-endpoint-does-not-show-latest-played-tracks/td-p/5284935/page/2) about this endpoint
h added 1 commit 2023-11-03 19:35:41 -04:00
h added 1 commit 2023-11-03 20:09:35 -04:00
h changed title from WIP: Spotify & database support to Spotify & database support 2023-11-03 20:10:15 -04:00
h merged commit ca50d4615a into main 2023-11-03 20:10:23 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: besties/yellowcab#1
No description provided.
Delete branch "astro/yellowcab:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?